Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graceful shutdown #34

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Implement graceful shutdown #34

merged 1 commit into from
Oct 17, 2021

Conversation

szaffarano
Copy link
Owner

fixes #32

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #34 (3a58de6) into master (68cc0bf) will decrease coverage by 1.85%.
The diff coverage is 53.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   89.22%   87.36%   -1.86%     
==========================================
  Files          10       11       +1     
  Lines         826      863      +37     
==========================================
+ Hits          737      754      +17     
- Misses         51       72      +21     
+ Partials       38       37       -1     
Impacted Files Coverage Δ
pkg/task/daemon.go 0.00% <0.00%> (ø)
pkg/task/transport/tls.go 96.15% <92.30%> (+1.86%) ⬆️
pkg/task/transport/server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cc0bf...3a58de6. Read the comment docs.

@szaffarano szaffarano marked this pull request as ready for review October 17, 2021 09:22
@szaffarano szaffarano merged commit 165c459 into master Oct 17, 2021
@szaffarano szaffarano deleted the 32-graceful-shutdown branch October 17, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement graceful shutdown
2 participants