Fix deploy.sh script #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh… please don’t merge this yet @szaghi let me rebase my changes onto the issues we fixed. This will make life much easier for you |
- *should* work now - exposed token should be resolved - better informational printing and error notifications - .travis.yml updated under the assumption that @szaghi moved to web interface for encrypted variables - removed empty .gitignore added when demonstrating security breach
|
OK, I rebased my fork onto the latest origin/master, so, if the checks pass and there are no merge conflicts it should be ready to merge. If the checks fail or there are merge conflicts, I’ll try to fix them for you, so hold off on merging if that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: I have removed the encrypted GH_TOKEN variable from the .travis.yml, so that it can be added directly on Travis-CI through the repository settings web interface. I think that using the web interface does a better job of making sure that variable contents don’t leak into the logs. Generate your new GH token then head over to: https://travis-ci.org/profile/szaghi and then click the gear ‘settings’ icon next to szaghi/FLAP. Then click on the ‘environment variables’ tab and ‘add new variable’. Then enter GH_TOKEN for the name and the corresponding newly generated token as the value. Make sure that the ‘display value in build logs’ setting is set to ‘off’. Please do this before attempting to merge this PR so we can see if the documentation deploys correctly and whether or not the token is exposed.