Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential BUG in FLAP (varying size parameters) #49

Merged
merged 1 commit into from
Aug 19, 2015

Conversation

victorsndvg
Copy link

Some minor changes related with the following issue:
#48

@codecov-io
Copy link

Current coverage is 65.24%

Merging #49 into master will increase coverage by +0.02% as of 6d939a0

@@            master     #49   diff @@
======================================
  Files            5       5       
  Stmts         2171    2172     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1416    1417     +1
  Partial          0       0       
  Missed         755     755       

Review entire Coverage Diff as of 6d939a0

Powered by Codecov. Updated on successful CI builds.

szaghi added a commit that referenced this pull request Aug 19, 2015
Potential BUG in FLAP (varying size parameters)
@szaghi szaghi merged commit af2d84b into szaghi:master Aug 19, 2015
@szaghi
Copy link
Owner

szaghi commented Aug 19, 2015

Thank you victor!

@victorsndvg
Copy link
Author

You'r welcome :)

We are not sure that this is a final fix for this problem...

I have some doubts.

Are you sure that you want to maintain allocated the cla%val if the argument is not passed?
Why you have both cla%val and cla%def? is cla%def status re-initialized?
Another option to fix this issue is to create a new flow for FLAP when cla%val is not allocated

@szaghi
Copy link
Owner

szaghi commented Aug 19, 2015

Cla%def is the one that must be used when a not required cla is gotten without being passed, thus I do not like to have cla%val allocated in this case, but as I said I am out of office and I cannot check it. Your workaround is nuce as temporary patch until I cannot check it. For this reason I prefer to leave open this issue. In the meanwhile, feel free to suggest other patches :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants