review comments

szehon-ho · Sep 16, 2024 · 42e73e6 · 42e73e6
1 parent 45369c7
commit 42e73e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/...c/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala b/...c/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala
@@ -303,10 +303,7 @@ object CheckConnectJvmClientCompatibility {
       ProblemFilters.exclude[DirectMissingMethodProblem](
         "org.apache.spark.sql.DataFrameReader.validateJsonSchema"),
       ProblemFilters.exclude[DirectMissingMethodProblem](
-        "org.apache.spark.sql.DataFrameReader.validateXmlSchema"),
-
-      // Update Writer
-      ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.sql.SparkSession.update"))
+        "org.apache.spark.sql.DataFrameReader.validateXmlSchema")
 
     checkMiMaCompatibility(clientJar, sqlJar, includedRules, excludeRules)
   }

diff --git a/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
@@ -1656,13 +1656,12 @@ class Dataset[T] private[sql](
   }
 
   /**
-   * Update rows in a table.
+   * Update rows in a table. Only applies to Datasets that are direct table scans.
    *
    * Scala Example:
    * {{{
    *   spark.table("source")
    *    .update(Map("salary" -> lit(200)))
-   *    .execute()
    * }}}
    * @param assignments A Map of column names to Column expressions representing the updates
    *     to be applied.
@@ -1674,21 +1673,23 @@ class Dataset[T] private[sql](
   }
 
   /**
-   * Update rows in a table that match a condition.
+   * Update rows in a table that match a condition. Only applies to Datasets that are
+   * direct table scans.
    *
    * Scala Example:
    * {{{
    *   spark.table("source")
    *    .update(Map("salary" -> lit(200)), $"salary" === 100)
-   *    .execute()
    * }}}
    * @param assignments A Map of column names to Column expressions representing the updates
    *     to be applied.
    * @param condition the update condition
    * @group basic
    * @since 4.0.0
    */
-  def update(assignments: Map[String, Column], condition: Column): Unit = {
+  def update(
+      assignments: Map[String, Column],
+      condition: Column): Unit = {
     updateInternal(assignments, Some(condition))
   }