fix svg viewBox bug 🎱 #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #439 |
jmeinke
reviewed
Jul 11, 2019
| @@ -563,9 +563,7 @@ export default class SignaturePad { | |||
| '<svg' + | |||
| ' xmlns="http://www.w3.org/2000/svg"' + | |||
| ' xmlns:xlink="http://www.w3.org/1999/xlink"' + | |||
| ` viewBox="${minX} ${minY} ${maxX} ${maxY}"` + | |||
| ` width="${maxX}"` + | |||
| ` height="${maxY}"` + | |||
There was a problem hiding this comment.
@mesqueeb Why did you remove width and height? It makes the tests fail.
There was a problem hiding this comment.
Sorry!
I never include it on my SVGs, viewBox should be enough.
jmeinke
reviewed
Jul 11, 2019
| @@ -1,5 +1,4 @@ | |||
| node_modules/ | |||
| dist/ | |||
There was a problem hiding this comment.
@mesqueeb Why are you adding the dist folder?
|
Unfortunately, I don't have the permissions to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem was here:
This should be set to the canvas width and height that the dev has chosen.