Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback values when options object contains explicit undefined values #772

Merged
merged 2 commits into from
May 18, 2024

Conversation

cyevgeniy
Copy link
Contributor

This PR allows to handle explicit undefined values in throttle, minDistance or canvasContextOptions fields.

Reproduction link: https://codepen.io/username1334/pen/mdYVWVN

In the reproduction above, signature pad doesn't work because minDistance is undefined.

Copy link
Collaborator

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@UziTech UziTech merged commit fe11e16 into szimek:master May 18, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request May 18, 2024
## [5.0.1](v5.0.0...v5.0.1) (2024-05-18)

### Bug Fixes

* Use fallback values when options object contains explicit `undefined` values ([#772](#772)) ([fe11e16](fe11e16))
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants