Fix image attach when creating confluence page #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbalint
force-pushed
the
mba_img_create
branch
from
a689a70
to
adb4736
Compare
|
Thanks @martinbalint for the PR! It also reminds me how badly this repo needs test automation. I'll do my best to test it and merge it in 2-3 days. |
szn
reviewed
Feb 21, 2024
|
|
||
| confluence_url = ConfluenceMD.get_link_from_response(response) | ||
| logger.debug( | ||
| "%s %s", 'Page overwritten' if overwrite else 'New page created', confluence_url | ||
| "%s %s", 'Page overwritten' if overwrite_id else 'New page created', confluence_url |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13 when creating page with images failed.
With this PR first page is created and then images are attached.