GenericGcodeDriver: Add support for grblHAL HTTP-upload and static jo… #220
Conversation
|
I modified my previous pull request to a simpler variant where you can only upload a file and have the option to provide a static name. Autostart is more difficult to implement with grlbhal and not needed for our use case (we want to have a physical button on the machine). So if needed, maybe that can be implemented later. Please merge this one :) |
|
@t-oster Do you have any chance to look at this? Sorry for being pushy by mentioning you, but I thought maybe you weren't noticed because the old PR was closed. |
|
By the way, I tested this and it covers our use case. |
|
Looks good, I would merge in a week if there are no new comments/changes. |
|
Cool, thanks. If that week could be a tiny little bit shorter (like merging on monday so we could start using it tuesday), that would be great.. :) |
…b name. Fixes #207