Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added arithmetic formatter #1

Merged
merged 1 commit into from
Oct 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions Arithmetic Formatter/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
### Assignment

Students in primary school often arrange arithmetic problems vertically to make them easier to solve. For example, "235 + 52" becomes:
```
235
+ 52
-----
```

Create a function that receives a list of strings that are arithmetic problems and returns the problems arranged vertically and side-by-side. The function should optionally take a second argument. When the second argument is set to `True`, the answers should be displayed.

### For example

Function Call:
```py
arithmetic_arranger(["32 + 698", "3801 - 2", "45 + 43", "123 + 49"])
```

Output:
```
32 3801 45 123
+ 698 - 2 + 43 + 49
----- ------ ---- -----
```

Function Call:
```py
arithmetic_arranger(["32 + 8", "1 - 3801", "9999 + 9999", "523 - 49"], True)
```

Output:
```
32 1 9999 523
+ 8 - 3801 + 9999 - 49
---- ------ ------ -----
40 -3800 19998 474
```

### Rules

The function will return the correct conversion if the supplied problems are properly formatted, otherwise, it will **return** a **string** that describes an error that is meaningful to the user.


* Situations that will return an error:
* If there are **too many problems** supplied to the function. The limit is **five**, anything more will return:
`Error: Too many problems.`
* The appropriate operators the function will accept are **addition** and **subtraction**. Multiplication and division will return an error. Other operators not mentioned in this bullet point will not need to be tested. The error returned will be:
`Error: Operator must be '+' or '-'.`
* Each number (operand) should only contain digits. Otherwise, the function will return:
`Error: Numbers must only contain digits.`
* Each operand (aka number on each side of the operator) has a max of four digits in width. Otherwise, the error string returned will be:
`Error: Numbers cannot be more than four digits.`
* If the user supplied the correct format of problems, the conversion you return will follow these rules:
* There should be a single space between the operator and the longest of the two operands, the operator will be on the same line as the second operand, both operands will be in the same order as provided (the first will be the top one and the second will be the bottom.
* Numbers should be right-aligned.
* There should be four spaces between each problem.
* There should be dashes at the bottom of each problem. The dashes should run along the entire length of each problem individually. (The example above shows what this should look like.)

### Development

Write your code in `arithmetic_arranger.py`. For development, you can use `main.py` to test your `arithmetic_arranger()` function. Click the "run" button and `main.py` will run.

### Testing

The unit tests for this project are in `test_module.py`. We imported the tests from `test_module.py` to `main.py` for your convenience. The tests will run automatically whenever you hit the "run" button.

### Submitting

Copy your project's URL and submit it to freeCodeCamp.
65 changes: 65 additions & 0 deletions Arithmetic Formatter/arithmetic_arranger.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
def arithmetic_arranger(problems, print_ans = False):
count = 1

if len(problems)>5:
return "Error: Too many problems."

line_1 = ""
line_2 = ""
dash_line = ""
ans_line = ""

for problem in problems:

chars = problem.split()

try :
num1 = int(chars[0])
operator = chars[1]
num2 = int(chars[2])
except :
return "Error: Numbers must only contain digits."

if len(chars[0])>4 or len(chars[2])>4 :
return "Error: Numbers cannot be more than four digits."

if chars[1] not in ["+", "-"]:
return "Error: Operator must be '+' or '-'."

if print_ans:
if operator == "+":
answer = num1 + num2
else:
answer = num1 - num2

maxx = num1
if num2>num1:
maxx = num2

str_num1 = str(num1).rjust(len(str(maxx))+2)
str_num2 = operator + str(num2).rjust(len(str(maxx))+1)

line_1 = line_1 + str_num1
line_2 = line_2 + str_num2
dash_line = dash_line + ("-"*(2+len(str(maxx))))



if print_ans:
ans_line = ans_line + str(answer).rjust(len(str(maxx))+2)

if count<len(problems) :
line_1 += " "
line_2 += " "
dash_line += " "
if print_ans:
ans_line += " "

count += 1

if print_ans:
arranged_problems = line_1 + "\n" + line_2 + "\n" + dash_line + "\n" + ans_line
else:
arranged_problems = line_1 + "\n" + line_2 + "\n" + dash_line

return arranged_problems
10 changes: 10 additions & 0 deletions Arithmetic Formatter/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This entrypoint file to be used in development. Start by reading README.md
from arithmetic_arranger import arithmetic_arranger
from unittest import main


print(arithmetic_arranger(["32 + 698", "3801 - 2", "45 + 43", "123 + 49"]))


# Run unit tests automatically
main(module='test_module', exit=False)
42 changes: 42 additions & 0 deletions Arithmetic Formatter/test_module.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import unittest
from arithmetic_arranger import arithmetic_arranger


# the test case
class UnitTests(unittest.TestCase):
def test_arrangement(self):
actual = arithmetic_arranger(["3 + 855", "3801 - 2", "45 + 43", "123 + 49"])
expected = " 3 3801 45 123\n+ 855 - 2 + 43 + 49\n----- ------ ---- -----"
self.assertEqual(actual, expected, 'Expected different output when calling "arithmetic_arranger()" with ["3 + 855", "3801 - 2", "45 + 43", "123 + 49"]')

actual = arithmetic_arranger(["11 + 4", "3801 - 2999", "1 + 2", "123 + 49", "1 - 9380"])
expected = " 11 3801 1 123 1\n+ 4 - 2999 + 2 + 49 - 9380\n---- ------ --- ----- ------"
self.assertEqual(actual, expected, 'Expected different output when calling "arithmetic_arranger()" with ["11 + 4", "3801 - 2999", "1 + 2", "123 + 49", "1 - 9380"]')

def test_too_many_problems(self):
actual = arithmetic_arranger(["44 + 815", "909 - 2", "45 + 43", "123 + 49", "888 + 40", "653 + 87"])
expected = "Error: Too many problems."
self.assertEqual(actual, expected, 'Expected calling "arithmetic_arranger()" with more than five problems to return "Error: Too many problems."')

def test_incorrect_operator(self):
actual = arithmetic_arranger(["3 / 855", "3801 - 2", "45 + 43", "123 + 49"])
expected = "Error: Operator must be '+' or '-'."
self.assertEqual(actual, expected, '''Expected calling "arithmetic_arranger()" with a problem that uses the "/" operator to return "Error: Operator must be '+' or '-'."''')

def test_too_many_digits(self):
actual = arithmetic_arranger(["24 + 85215", "3801 - 2", "45 + 43", "123 + 49"])
expected = "Error: Numbers cannot be more than four digits."
self.assertEqual(actual, expected, 'Expected calling "arithmetic_arranger()" with a problem that has a number over 4 digits long to return "Error: Numbers cannot be more than four digits."')

def test_only_digits(self):
actual = arithmetic_arranger(["98 + 3g5", "3801 - 2", "45 + 43", "123 + 49"])
expected = "Error: Numbers must only contain digits."
self.assertEqual(actual, expected, 'Expected calling "arithmetic_arranger()" with a problem that contains a letter character in the number to return "Error: Numbers must only contain digits."')

def test_solutions(self):
actual = arithmetic_arranger(["32 - 698", "1 - 3801", "45 + 43", "123 + 49"], True)
expected = " 32 1 45 123\n- 698 - 3801 + 43 + 49\n----- ------ ---- -----\n -666 -3800 88 172"
self.assertEqual(actual, expected, 'Expected solutions to be correctly displayed in output when calling "arithmetic_arranger()" with arithemetic problems and a second argument of `True`.')

if __name__ == "__main__":
unittest.main()