feat: use typescript-eslint's recommended-requiring-type-checking

[JoshuaKGoldberg]

Closes #1035

✅ Checklist

• I have followed every step in the contributing guide (updated 2022-10-06).
• The PR title follows the convention we established conventional-commit
• I performed a functional test on my final commit

---

Changelog

Augments the internal/CLI and user-generated ESLint configs to extend from plugin:@typescript-eslint/recommended-requiring-type-checking.

---

Screenshots

...n/a?

💯

[changeset-bot]

🦋 Changeset detected

Latest commit: 61916e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-t3-app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
create-t3-app	✅ Ready (Inspect)	Visit Preview	Jan 7, 2023 at 10:15PM (UTC)

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	100
🟢 Accessibility	100
🟢 Best practices	100
🟠 SEO	86
🟠 PWA	54

Lighthouse ran on https://create-t3-app-git-fork-joshuakgoldberg-typescript-1e820b-t3-oss.vercel.app/

[c-ehrlich]

Looks great, thanks for putting in all this work! After reading back my comments, some of them don't really relate to the PR itself I guess, but this seems like as good a place as any to bring them up.

I'd basically be fine to approve this as is, but want to leave it open for a few days to allow everyone else to read it and discuss.

[JoshuaKGoldberg]

that an type is going to be replaced with an interface

That's from the default rule configurations: specifically how @typescript-eslint/consistent-type-definitions is configured. That rule isn't enabled in the recommended or recommended-requiring-type-checking presets. So this PR shouldn't change that. 🙂

[juliusmarminge]

@JoshuaKGoldberg I'm getting tons of yellow squigglies in VSCode but no reported errors in the CLI:

Is this what you meant with the anys here and circular dep?

[juliusmarminge]

This is a super weird one... says unsafe assignment of type any but it says the variable is a string... 🤯

[JoshuaKGoldberg]

@juliusmarminge yes, exactly! What you're seeing is a bug: TypeScript says one thing (e.g. string) in both the tsc CLI and in the IDE, but when typescript-eslint asks it for, the type is reported as any. There's a good chance this will be fixed in TypeScript v5. But I'm not sure.

In the meantime, I'll just disable the rules with a sad comment.

[juliusmarminge]

Awesome job. Thanks a lot!