Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added drizzle doc page in english #1659

Closed
wants to merge 2 commits into from
Closed

docs: added drizzle doc page in english #1659

wants to merge 2 commits into from

Conversation

ThomasBouasli
Copy link

Closes #1613

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added docs page for Drizzle ORM

Screenshots

image

💯

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 536ac72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved		 Dec 7, 2023 4:09am

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023

@ThomasBouasli is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 14, 2023
barrybtw
barrybtw suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@barrybtw barrybtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording changes

@ThomasBouasli
Copy link
Author

Actually, don't merge this PR yet, just realize that I missed 2/3 topics in the original issue

  • Update the Drizzle documentation page
  • Add Drizzle to why.md
  • Add Drizzle to introduction.md

@ThomasBouasli ThomasBouasli mentioned this pull request Dec 10, 2023
Open
Arkirion
Arkirion reviewed Jan 21, 2024
View reviewed changes
www/src/pages/en/usage/drizzle.md
Comment on lines +24 to +25
The default database is a MySql database, using the PlanetScale serverless client, so it is edge ready out of the box! All you need to do is spin up a database at PlanetScale (up to one instance in free-tier BTW) and copy and paste the connection string in the `.env` file. Don't forget to add `ssl={"rejectUnauthorized":true}` to the end of the string.

Copy link

@Arkirion Arkirion Jan 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently if you can pick Drizzle on planetscale it will do not give you any string.
On .env.example or .env there's next explanation :

# Drizzle
# Get the Database URL from the "prisma" dropdown selector in PlanetScale.

It was a little bit weird until I understood that if you use Prisma string will work, you might clarify this here

image

@ThomasBouasli
Copy link
Author

I wont have the time to do this well enough, if anyone else wants to pick up where I left of feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkirion Arkirion Arkirion left review comments

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge juliusmarminge is a code owner

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

@barrybtw barrybtw Awaiting requested review from barrybtw

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Update Drizzle document
4 participants
@ThomasBouasli @Arkirion @barrybtw @tbouasli