[FEATURE] make logo carousel linked logos same size as non linked logos. #409
Conversation
ghost
deleted the
|
accidentally deleted the wrong branch.... |
ghost
reopened this
| @@ -7,10 +7,6 @@ | |||
| padding: 0 30px; | |||
| } | |||
|
|
|||
| .logo-carousel__slide { | |||
| padding: 10px 30px; | |||
There was a problem hiding this comment.
I do not agree with this fix. If you remove padding from class .logo-carousel__slide it will be removed not only from the image without a link but also from the image with a link which causes problems in logo carousel element (logos will be too big)
There was a problem hiding this comment.
At the moment the linked logos are smaller than the non linked logos.
This fixes the size difference.
We did not have any problems with to big logos.
Do you have an example so we can reproduce it?
There was a problem hiding this comment.
padding: 10px 30px;
- padding: 10px 30px;
There was a problem hiding this comment.
Here is a Screenshot of what I mean:
The Problem is that there is some css styling on the .logo-carousel__link class which means when there is no link set there is some styling missing.
The only visible difference is the padding.
I can either make the icons all the smaller size or the larger size, which one would you like?
There was a problem hiding this comment.
My main concerns are that this fix can cause changes in existing websites after the update as I showed it on screenshots above. So you need to add changes without changing existed behavior. I would suggest making not linked files smaller.
|
I have updated the
Since this is a pull request of changes to the behavior it will change behavior... Anyway I updated the PR to make non linked and linked logos the same size and styling without touching existing styles. |
There is a size difference in the logo-carousel logos, when they are linked and when they are not.
Linked Logos are smaller compared to the not linked ones.