[FIX] Jarallax issues #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pxamike
commented
Jun 14, 2018
pxamike
commented
- Upgrade jarallax to 1.10.3 (to be able to use disableParallax option)
- Javascript fix for .parallax-resimg when fetching the background-image -url from css.
- Fix of Parallax.html template and javascript to make sure parallax videos are triggered only by the javascript (like the images area) - fixes parallax-video called by data-values instead of by javascript #423
- Disable parallax-effect for images in Microsoft Edge as they are buggy in EdgeHTML 17. ( EdgeHTML 17 and visual issues with demonstration-page nk-o/jarallax#110 )
- Updated the javascript configuration for it.
…enerally lags and doesn't currently work in EdgeHTML17 (see issue #110 in github)
- changed attribute on parallax-video from data-jarallax-video to data-video-url. - changed javascript for parallax-video to use this field - removed css for parallax that overwrote the background-image (the js of jarallax takes cares of this) - we can't disable parallax for Edge on video-elements without also disabling the video, so enabled it again (compared to images it does seem to work in latest Edge) - compileLess, compiledCss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.