Added filterOption functionality #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added filterOption functionality
|
Thank you for your efforts and PR. But I would like to hold this change for now. Let me consider these filter improvements in future. |
|
Any plans to add this functionality in the future? Or does this not fit in roadmap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filterOption functionality.
This is an initial version which
Note that some css styling + layout is probably not optimal.
Also the db.js is not yet updated to support these new functionality. Also unit-tests are not updated.
Please review my changes and see if you can understand them and if possible add these to the main branch from js-grid.