-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should toggle-visibility have contain:paint or at least its z-ordering effects (stacking context) all of the time? #38
Comments
One possibility is that That said, it seems less necessary, and perhaps undesirable, to have all the containment effects when the toggle is active. However, I think the z-ordering effects are needed, and there may be other aspects of containment that I'm not thinking of that either are useful for the visible state or useful to switch states efficiently. |
That said, |
Yeah, I think that's just badly written on my part. The intention is definitely what you suggested, where it acts like |
(Like, I'm still not entirely certain I shouldn't just be using |
"like a new value of |
(An interesting question for the case of keeping it a distinct property is what to do when both |
Yeah, I think the behavior we want is that toggle-visibility can apply hidden-ness in addition to things like content-visibility. |
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922815 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058772}
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922815 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058772}
See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922815 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058772}
…., a=testonly Automatic update from web-platform-tests Implement toggle-visibility CSS property. See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922815 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058772} -- wpt-commits: 4469e89eb413d5f44699210b736bdb98b6b3333f wpt-pr: 36264
…., a=testonly Automatic update from web-platform-tests Implement toggle-visibility CSS property. See specification: https://tabatkins.github.io/css-toggle/#toggle-visibility-property and clarifying discussion in: tabatkins/css-toggle#38 (Support for toggles is behind the CSSToggles flag, which is currently off.) Bug: 1250716 Change-Id: Ib29d879b7ba81dcfe95cb59fe6e6b66f0e24e528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922815 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058772} -- wpt-commits: 4469e89eb413d5f44699210b736bdb98b6b3333f wpt-pr: 36264
Right now
toggle-visibility
not beingnormal
acts likecontent-visibility: auto
is present only when the toggle is in the inactive state. This impliescontain: paint
, which has z-ordering effects, which means that an element withtoggle-visibility
!=normal
has a higher default z-order when its contents are hidden than when its contents are visible.This seems like it might be undesirable.
Perhaps it would make sense to imply some of the containment, or at least the z-ordering effects of
contain:paint
(i.e., creating a stacking context), whenevertoggle-visibility
is notnormal
rather than only when the toggle is inactive.The text was updated successfully, but these errors were encountered: