New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO iframe #1

Open

olizilla wants to merge 1 commit into master from byo-iframe

Member

olizilla commented Jan 24, 2017

As per @richsilv's good idea, this PR refactors things to let caller pass in an iframe or other responsively embeddable thing.

Usage would now look like:

<ResponsiveEmbed ratio='4:3'>
  <iframe src='https://www.youtube.com/embed/2yqz9zgoC-U' allowfullscreen />
</ResponsiveEmbed>

if no ratio is provided then 16:9 is assumed


          Refactor to let caller pass in an iframe or other

40241ea

olizilla mentioned this pull request

Warning: Unknown prop ratio on <iframe> #3

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet