Starts working on making ERC20 functions compliant and fixing ERC1404. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| emit Transfer(p.from, p.to, p.amount); | ||
| } | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
Clever... using 0 to signify it's ok (1404 spec), then return a specific uint8 for the code if the conditions don't pass. Using dryrun etc to ring fence state changing logic. Nice man 👍. Then you'll use this in dry run mode for detectTransferRestriction (1404)?
There was a problem hiding this comment.
You're correct - my objective was to allow for a single source of algorythmic truth shared between transfer functions and detectTransferRestriction functions...
| @@ -107,7 +135,7 @@ abstract contract AFastFacet is IFastEvents { | |||
| * @param b Address b | |||
| */ | |||
| modifier differentAddresses(address a, address b) { | |||
| require(a != b, LibConstants.REQUIRES_DIFFERENT_SENDER_AND_RECIPIENT); | |||
| require(a == b, LibConstants.REQUIRES_DIFFERENT_SENDER_AND_RECIPIENT); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.