Skip to content

Commit

Permalink
engine: only override write stall configurations if unspecified (tikv…
Browse files Browse the repository at this point in the history
…#12127)

ref tikv#11424, ref tikv#11840

Signed-off-by: tabokie <xy.tao@outlook.com>
  • Loading branch information
tabokie committed Jun 2, 2022
1 parent 9123094 commit b05e449
Show file tree
Hide file tree
Showing 3 changed files with 268 additions and 103 deletions.
20 changes: 16 additions & 4 deletions etc/config-template.toml
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@
## Maximum number of level-0 files.
## When the number of SST files of level-0 reaches the limit of `level0-stop-writes-trigger`,
## RocksDB stalls the new write operation.
# level0-stop-writes-trigger = 36
# level0-stop-writes-trigger = 20

## Amount of data to build up in memory (backed by an unsorted log on disk) before converting to a
## sorted on-disk file. It is the RocksDB MemTable size.
Expand Down Expand Up @@ -719,6 +719,12 @@
## "min-overlapping-ratio"
# compaction-pri = "min-overlapping-ratio"

## Refer to storage.flow-control.soft-pending-compaction-bytes-limit.
# soft-pending-compaction-bytes-limit = "192GB"

## Refer to storage.flow-control.hard-pending-compaction-bytes-limit.
# hard-pending-compaction-bytes-limit = "1000GB"

## Indicating if we'd put index/filter blocks to the block cache.
## If not specified, each "table reader" object will pre-load index/filter block during table
## initialization.
Expand Down Expand Up @@ -833,10 +839,12 @@

# level0-file-num-compaction-trigger = 4
# level0-slowdown-writes-trigger = 20
# level0-stop-writes-trigger = 36
# level0-stop-writes-trigger = 20
# cache-index-and-filter-blocks = true
# pin-l0-filter-and-index-blocks = true
# compaction-pri = "min-overlapping-ratio"
# soft-pending-compaction-bytes-limit = "192GB"
# hard-pending-compaction-bytes-limit = "1000GB"
# read-amp-bytes-per-bit = 0
# dynamic-level-bytes = true
# optimize-filters-for-hits = false
Expand All @@ -854,10 +862,12 @@
# target-file-size-base = "8MB"
# level0-file-num-compaction-trigger = 1
# level0-slowdown-writes-trigger = 20
# level0-stop-writes-trigger = 36
# level0-stop-writes-trigger = 20
# cache-index-and-filter-blocks = true
# pin-l0-filter-and-index-blocks = true
# compaction-pri = "by-compensated-size"
# soft-pending-compaction-bytes-limit = "192GB"
# hard-pending-compaction-bytes-limit = "1000GB"
# read-amp-bytes-per-bit = 0
# dynamic-level-bytes = true
# optimize-filters-for-hits = false
Expand Down Expand Up @@ -911,10 +921,12 @@

# level0-file-num-compaction-trigger = 4
# level0-slowdown-writes-trigger = 20
# level0-stop-writes-trigger = 36
# level0-stop-writes-trigger = 20
# cache-index-and-filter-blocks = true
# pin-l0-filter-and-index-blocks = true
# compaction-pri = "by-compensated-size"
# soft-pending-compaction-bytes-limit = "192GB"
# hard-pending-compaction-bytes-limit = "1000GB"
# read-amp-bytes-per-bit = 0
# dynamic-level-bytes = true
# optimize-filters-for-hits = true
Expand Down
Loading

0 comments on commit b05e449

Please sign in to comment.