Skip to content

Commit

Permalink
Enforce checkout with LF
Browse files Browse the repository at this point in the history
Windows CI fails when parsing CSV with line breaks within a cell. This
is due to the difference of line endings between CRLF vs LF, and test
CSV parser implementation.

To mitigate this issue, tweak Windows CI to enforce git checkout with LF.
  • Loading branch information
chezou authored and jazzido committed Feb 21, 2023
1 parent 3c2af18 commit b0fde49
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/tests-windows.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Java CI
name: Java CI (Windows)

on: [push]

Expand All @@ -7,9 +7,14 @@ jobs:
runs-on: windows-latest

steps:
- uses: actions/checkout@v2
# https://github.com/actions/checkout/issues/135#issuecomment-602171132
- name: Set git to use LF
run: |
git config --global core.autocrlf false
git config --global core.eol lf
- uses: actions/checkout@v3
- name: Set up JDK 11
uses: actions/setup-java@v2
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'adopt'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up JDK 11
uses: actions/setup-java@v2
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'adopt'
Expand Down

0 comments on commit b0fde49

Please sign in to comment.