Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blade component #13

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Added blade component #13

merged 2 commits into from
Sep 28, 2020

Conversation

tabuna
Copy link
Owner

@tabuna tabuna commented Sep 27, 2020

Hey. I think it would be nice to have a component for determining breadcrumbs directly from the package.

It would be a straightforward definition, for example:

<x-tabuna-breadcrumbs/>

To define classes of list items, you can specify:

<x-tabuna-breadcrumbs
  class="item"
  active="active"
/>

You can also pass parameters:

<x-tabuna-breadcrumbs
    parameters="['value 1', 'value 2', 'value 3']"
/>

And call named routes explicitly:

<x-tabuna-breadcrumbs
    route="static"
/>

@tabuna tabuna added the enhancement New feature or request label Sep 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #13 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     97.91%   98.23%   +0.31%     
- Complexity       35       41       +6     
============================================
  Files             7        8       +1     
  Lines            96      113      +17     
============================================
+ Hits             94      111      +17     
  Misses            2        2              
Impacted Files Coverage Δ Complexity Δ
src/BreadcrumbsComponent.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/BreadcrumbsServiceProvider.php 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5b3d6...39ea8b4. Read the comment docs.

@tabuna tabuna merged commit 2142616 into master Sep 28, 2020
@tabuna tabuna deleted the component branch September 28, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants