Replace opis/closure with laravel/serializable-closure #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdullahsari
commented
Oct 15, 2021
| if ($securityProvider !== null) { | ||
| SerializableClosure::addSecurityProvider($securityProvider); | ||
| } | ||
|
|
||
| if (is_a($callback, SerializableClosure::class)) { |
There was a problem hiding this comment.
I'm not sure why this check is there, so did not touch it. Is it ever possible to receive something other than a SerializableClosure?
There was a problem hiding this comment.
I did not find an expectation of a type other than SerializableClosure. Removed check. Thanks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30.
callabletoClosurein theRoutemacro is technically a breaking change, but the chances somebody is using anything but aClosureas acallableis very very slim. The charm of this package is the ability to use Closures in the route definition. 🤙🏻 (This is needed because Laravel'sSerializableClosureonly accepts actualClosures.)EncryptionServiceProvider, it is probably safe to omit the temporary security provider overrides in the middleware.