Remove IE7 CSS hack #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this [star property hack](https://stackoverflow.com/a/14927670/808699) that was targeting IE 5.5 to 7. It causes warnings during ESBuild's CSS minification and IE 7 has a global market share of 0.01% so I think it can be safely dropped. Fixes: tachyons-css#62
silverwind
force-pushed
the
remove-star-hack
branch
from
d71f153
to
221e436
Compare
17 tasks
17 tasks
|
@mrmrs would you find time to review this PR and release a new release of |
17 tasks
|
Thanks for the suggestion, this code is generated from the main tachyons code, so generally changes like this happen in the main repo. Not planning to drop * from v4 but considering for v5. I'm wary of changing this code in v4 to deal with an external minification pipeline. I might suggest keeping your own fork. v4 changes should be light as most efforts are focused on v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this star property hack that was targeting IE 5.5 to 7.
It causes warnings during ESBuild's CSS minification and IE 7 has a global market share of 0.01% so I think it can be safely dropped.