TACT-111: Goal setting rework #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…tings � Conflicts: � components/shared/Task/store.ts � components/shared/TaskQuickEditor/store.ts � components/shared/TasksList/components/TaskItemMenu/index.tsx � package-lock.json � package.json
kamilsk
approved these changes
Mar 27, 2023
kamilsk
reviewed
Mar 30, 2023
assets/images/mascot-goals.png
Outdated
There was a problem hiding this comment.
@al-petrushin, why png? why not svg?
| @@ -0,0 +1,36 @@ | |||
| import { Flex, Text } from "@chakra-ui/react"; | |||
| import ImageComponent from "../../../../shared/Image"; | |||
| import mascotGoals from "../../../../../assets/images/mascot-goals.png"; | |||
There was a problem hiding this comment.
where are our other assets? don't see assets folder on the root.
| My Goals | ||
| <Heading | ||
| size='md' | ||
| fontSize="2xl" |
There was a problem hiding this comment.
I think we have to set up linter and pretier
| </Fade> | ||
| </Portal> | ||
| ); | ||
| }); |
…tings � Conflicts: � package-lock.json � package.json
kamilsk
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
TACT-111
Describe the pull request
Creating and editing goal in new design