Feat: scope search cleaned #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
roschaefer
force-pushed
the
feat/scope-search-cleaned
branch
from
ca2e160 to
308f69f
Compare
roschaefer
added a commit
that referenced
this pull request
Aug 9, 2024
Motivation ---------- I used these seeds to review #1964. What I observed is that the list of requests is visible across all organizations but the search is scoped. I.e. if you search, you have no search results. That's why I updated the seeds here, to check if the error persists for only one organization. Answer: no How to test ----------- 1. `git switch main` or `git switch update_seeds_fill` 1. `bin/rails db:seeds:fill` 2. Do a full text search 3. On `main` you won't see anything but on this branch you will
roschaefer
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
I tested it with #1968 and it looked fine.
The list of requests on /requests is not scoped at all at the moment.
roschaefer
force-pushed
the
feat/scope-search-cleaned
branch
from
308f69f to
e0091ea
Compare
|
Closed by accident |
soey
pushed a commit
that referenced
this pull request
Aug 14, 2024
Motivation ---------- I used these seeds to review #1964. What I observed is that the list of requests is visible across all organizations but the search is scoped. I.e. if you search, you have no search results. That's why I updated the seeds here, to check if the error persists for only one organization. Answer: no How to test ----------- 1. `git switch main` or `git switch update_seeds_fill` 1. `bin/rails db:seeds:fill` 2. Do a full text search 3. On `main` you won't see anything but on this branch you will
roschaefer
added a commit
that referenced
this pull request
Aug 16, 2024
Motivation ---------- I used these seeds to review #1964. What I observed is that the list of requests is visible across all organizations but the search is scoped. I.e. if you search, you have no search results. That's why I updated the seeds here, to check if the error persists for only one organization. Answer: no How to test ----------- 1. `git switch main` or `git switch update_seeds_fill` 1. `bin/rails db:seeds:fill` 2. Do a full text search 3. On `main` you won't see anything but on this branch you will
roschaefer
added a commit
that referenced
this pull request
Aug 16, 2024
Motivation ---------- I used these seeds to review #1964. What I observed is that the list of requests is visible across all organizations but the search is scoped. I.e. if you search, you have no search results. That's why I updated the seeds here, to check if the error persists for only one organization. Answer: no How to test ----------- 1. `git switch main` or `git switch update_seeds_fill` 1. `bin/rails db:seeds:fill` 2. Do a full text search 3. On `main` you won't see anything but on this branch you will
mattwr18
pushed a commit
that referenced
this pull request
Aug 29, 2024
mattwr18
pushed a commit
that referenced
this pull request
Aug 29, 2024
Motivation ---------- I used these seeds to review #1964. What I observed is that the list of requests is visible across all organizations but the search is scoped. I.e. if you search, you have no search results. That's why I updated the seeds here, to check if the error persists for only one organization. Answer: no How to test ----------- 1. `git switch main` or `git switch update_seeds_fill` 1. `bin/rails db:seeds:fill` 2. Do a full text search 3. On `main` you won't see anything but on this branch you will
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.