[fix] scope requests controller to organization #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwr18
force-pushed
the
feat/scope-requests-controller
branch
3 times, most recently
from
4868571 to
84e0454
Compare
mattwr18
force-pushed
the
feat/scope-requests-controller
branch
from
731e3ee to
4c1af4c
Compare
mattwr18
commented
Sep 2, 2024
mattwr18
commented
Sep 2, 2024
soey
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Quite interesting in how far the request specs escalate with the authentication and authorization - whereas this seems to be justified & needed from the functionality perspective it bothers me somehow that we need to repeat it all over again. Overall the functionality side is all good. I would propose to revise the specs and make them as concise and understandable as possible.
soey
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.