[improvement] Improve create api key flow #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- let's keep onboarding for contributors and setup for users
mattwr18
force-pushed
the
2045_improve_create_api_key_flow
branch
from
592cf97 to
4db6eec
Compare
roschaefer
approved these changes
Oct 22, 2024
| layout 'minimal' | ||
|
|
||
| def create_api_key | ||
| channel_ids = create_api_key_params[:channels].split('[').last.split(']').last.split(',') |
There was a problem hiding this comment.
Suggested change
| channel_ids = create_api_key_params[:channels].split('[').last.split(']').last.split(',') | |
| channel_ids = YAML::load(create_api_key_params[:channels]) |
config/locales/de.yml
Outdated
| @@ -529,6 +529,9 @@ de: | |||
| threema_unknown_content_message: | |||
| label: Fehler-Nachricht bei unbekannten Inhalten | |||
| help: Wenn ein Mitglied via Threema Nachrichten versendet, die von 100eyes noch nicht unterstützt werden, erhält es diese Nachricht. | |||
| whats_app_setup: | |||
| success_heading: WhatsApp wurde erfolgreich konfiguriert | |||
| success_text: Du kannst nun mit der Einbindung von WhatsApp-Mitgliedern beginnen. | |||
There was a problem hiding this comment.
Suggested change
| success_text: Du kannst nun mit der Einbindung von WhatsApp-Mitgliedern beginnen. | |
| success_text: Du kannst jetzt Mitglieder über WhatsApp einladen. |
| subject.call | ||
| expect(response).to be_successful | ||
| expect(page).to have_content('WhatsApp wurde erfolgreich konfiguriert') | ||
| expect(page).to have_content('Du kannst nun mit der Einbindung von WhatsApp-Mitgliedern beginnen.') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2045