Allow to raise application errors in ElementWriter::write_inner_content
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
force-pushed
the
custom-errors-in-writing
branch
from
b8d154d
to
0ea9f74
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #652 +/- ##
==========================================
- Coverage 64.47% 64.46% -0.01%
==========================================
Files 36 36
Lines 17315 17315
==========================================
- Hits 11163 11162 -1
- Misses 6152 6153 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sometimes TortoiseGit loses commits during rebase... What a dangerous bug
Mingun
force-pushed
the
custom-errors-in-writing
branch
from
0ea9f74
to
d4f0621
Compare
dralley
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619.
@harmic, FYI