-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Config
struct that holds parser configuration and implement #513
#677
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
47f3638
Add explicit tests for `expand_empty_elements` reader option
Mingun 27cb615
Add explicit tests for `trim_text` reader option
Mingun d58c8bc
Add explicit tests for `trim_text_end` reader option
Mingun 4176571
Add explicit tests for `trim_markup_names_in_closing_tags` reader option
Mingun 86ccc0a
Add explicit tests for `check_end_names` reader option
Mingun 7980448
#513: Allow to continue parsing after `Error::IllFormed`
Mingun 475a883
Add explicit tests for `check_comments` reader option
Mingun 8101e29
Introduce `.config()` and `.config_mut()` and replace builder methods…
Mingun 77af4b3
Set the whole reader config in fuzzing tests
Mingun 75b4028
Sort options (mostly) alphabetically
Mingun 3875bdb
Add explicit tests for `trim_text_start` reader option
Mingun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
//! Contains tests for config options of a parser. | ||
//! | ||
//! Each module has a name of a corresponding option and functions inside performs | ||
//! testing of various option values. | ||
//! | ||
//! Please keep tests sorted (exceptions are allowed if options are tightly related). | ||
|
||
use quick_xml::events::{BytesEnd, BytesStart, Event}; | ||
use quick_xml::reader::Reader; | ||
|
||
mod expand_empty_elements { | ||
use super::*; | ||
use pretty_assertions::assert_eq; | ||
|
||
/// Self-closed elements should be reported as one `Empty` event | ||
#[test] | ||
fn false_() { | ||
let mut reader = Reader::from_str("<root/>"); | ||
reader.expand_empty_elements(false); | ||
|
||
assert_eq!( | ||
reader.read_event().unwrap(), | ||
Event::Empty(BytesStart::new("root")) | ||
); | ||
assert_eq!(reader.read_event().unwrap(), Event::Eof); | ||
} | ||
|
||
/// Self-closed elements should be reported as two events | ||
#[test] | ||
fn true_() { | ||
let mut reader = Reader::from_str("<root/>"); | ||
reader.expand_empty_elements(true); | ||
|
||
assert_eq!( | ||
reader.read_event().unwrap(), | ||
Event::Start(BytesStart::new("root")) | ||
); | ||
assert_eq!( | ||
reader.read_event().unwrap(), | ||
Event::End(BytesEnd::new("root")) | ||
); | ||
assert_eq!(reader.read_event().unwrap(), Event::Eof); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "enabled" and "disabled" would be better names, to avoid keyword clashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose those words because if we will have other options that are not booleans, tests would be named as a config value