Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de: consider local name only for namespaced tags in structs with $value #736

Closed
wants to merge 2 commits into from
Closed

de: consider local name only for namespaced tags in structs with $value #736

wants to merge 2 commits into from

Commits on Apr 12, 2024

  1. de: consider local_name only for namespaced tags in structs with $value 

    This updates the "not_in" check that decides whether to pass a
new start tag within a struct to a $value field, to only consider
the local part of a QName. It now uses the same decode_name function
as the QNameDeserializer that is used for keys/fields already to
ensure they stay in sync.

Using the namespaced name in serde (i.e. `#[serde(rename = "ns1:tag")]`)
fails with ``Custom("missing field `ns1:tag`")`` today, so this will
not break existing code.

Might help with tafia#347
    @Xiphoseer
    Xiphoseer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6f7dda4 View commit details
    Browse the repository at this point in the history

  2. Extend test_not_in

    @Xiphoseer
    Xiphoseer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    745278a View commit details
    Browse the repository at this point in the history