Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing instruction parsing #753

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 5, 2024

Handle the situation with parsing <?pi >?>. Previously we erroneously consume only <?pi > and return error about not closed processing instruction.

…, `>`, `'` and `"`

failures (3):
    reader::async_tokio::test::read_event_into_async::processing_instruction
    reader::buffered_reader::test::read_event_impl::processing_instruction
    reader::slice_reader::test::read_event_impl::processing_instruction
@Mingun Mingun added the bug label Jun 5, 2024
Fixes (3):
    reader::async_tokio::test::read_event_into_async::processing_instruction
    reader::buffered_reader::test::read_event_impl::processing_instruction
    reader::slice_reader::test::read_event_impl::processing_instruction
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.34884% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.82%. Comparing base (5d76174) to head (6231ac0).
Report is 23 commits behind head on master.

Files Patch % Lines
src/reader/buffered_reader.rs 87.87% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   61.24%   61.82%   +0.57%     
==========================================
  Files          39       40       +1     
  Lines       16277    16728     +451     
==========================================
+ Hits         9969    10342     +373     
- Misses       6308     6386      +78     
Flag Coverage Δ
unittests 61.82% <95.34%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release soon would be a good idea, the changelog is getting sizable

@Mingun Mingun merged commit 385a1f8 into tafia:master Jun 5, 2024
6 checks passed
@Mingun Mingun deleted the fix-pi-parsing branch June 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants