set default request timeout of 60 seconds, configurable #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashrsm
reviewed
Nov 11, 2021
Comment on lines
+368
to
+384
| /// ```rust | ||
| /// use goose::util; | ||
| /// | ||
| /// // No decimal returns a proper float. | ||
| /// assert_eq!(util::get_float_from_string(Some("1".to_string())), Some(1.0)); | ||
| /// | ||
| /// // Leading decimal returns a proper float. | ||
| /// assert_eq!(util::get_float_from_string(Some(".1".to_string())), Some(0.1)); | ||
| /// | ||
| /// // Valid float string returns a proper float. | ||
| /// assert_eq!(util::get_float_from_string(Some("1.1".to_string())), Some(1.1)); | ||
| /// | ||
| /// // Invalid number with too many decimals returns None. | ||
| /// assert_eq!(util::get_float_from_string(Some("1.1.1".to_string())), None); | ||
| /// | ||
| /// // No number returns None. | ||
| /// assert_eq!(util::get_float_from_string(None), None); |
jeremyandrews
force-pushed
the
timeout
branch
from
798dcf6
to
36fcb65
Compare
jeremyandrews
force-pushed
the
timeout
branch
from
36fcb65
to
366bc9d
Compare
LionsAd
reviewed
Nov 16, 2021
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--timeout VALUEwhere VALUE is seconds as integer or a float; timeout can be configured programatically usingGooseDefault::Timeoututils::get_float_from_string(), now used byutils::get_hatch_rate()set_client_builder()documentation to reflect how this changes the default Reqwest Client configuration