Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for requests per second graph in HTML report #392

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

slashrsm
Copy link
Collaborator

This is a follow-up of #381 and is part of #246.

@slashrsm slashrsm marked this pull request as ready for review November 22, 2021 12:35
@slashrsm
Copy link
Collaborator Author

In order to reliably test this hunk I would need to control the return value of Utc::now(). There is a pull request that allows that, but it is still in progress.

Until that is in we could add something on GooseAttack that would wrap Utc::now() and let us override it in tests. Not ideal since we would be polluting code with test-only logic. @jeremyandrews @LionsAd Any ideas/thoughts?

@jeremyandrews
Copy link
Member

@slashrsm There's plenty of places in the code not currently tested. Perhaps we add a comment w/ a @todo linking to the PR in question as a reminder to add a test when it's available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants