New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't panic when truncating non-utf8 #568

Merged

jeremyandrews merged 2 commits into tag1consulting:main from jeremyandrews:unicode

Nov 8, 2023

Member

jeremyandrews commented Oct 30, 2023 •

edited

Loading

implement non-utf8-specific truncation
add tests to confirm truncate_string() works with Japanese, Chinese, and Korean characters
fixes panic: assertion failed: self.is_char_boundary(new_len) when transaction!(xx).set_name("一二三四五六七") #567

jeremyandrews assigned LionsAd, slashrsm and alecsmrekar


          don't panic when truncating non-utf8

9c44acf

jeremyandrews force-pushed the unicode branch from 2c8618b to 9c44acf Compare

November 1, 2023 09:05


          document; add Chinese and Korean characters to tests

aee0175

LionsAd approved these changes

View reviewed changes

jeremyandrews merged commit f073609 into tag1consulting:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet