Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-106 Utilize pgbouncer to pool connections into PostGIS #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Feb 26, 2023

Addresses #106
@renato2099 a couple of issues here

  1. You will see the following message upon pgbouncer container initialization
tagbase-server-pgbouncer-1       | pgbouncer 05:23:09.34 WARN  ==> You set the environment variable PGBOUNCER_AUTH_TYPE=trust. For safety reasons, do not use this flag in a production environment.

We need to change the auth_type via the PGBOUNCER_AUTH_TYPE environment variable.
2. You need to augment .env and add the following build arg

docker-compose build ... --build-arg PGBOUNCER_PORT="6432"

This means that the new complete build command looks like

docker-compose build --build-arg NGINX_PASS="tagbase" --build-arg NGINX_USER="tagbase" --build-arg PGBOUNCER_PORT="6432"  --build-arg POSTGRES_PASSWORD="tagbase" --build-arg POSTGRES_PORT="5432"

I need to augment the installation documentation to account for this. I will do that once we merge this PR into main.

I would like to load test this implementation with Locust. Have you used that framework before? The load testing could also be part of this PR... let me know what you think. Thanks

@lewismc lewismc added enhancement New feature or request storage Anything tagbase-server storage/persistence related. labels Feb 26, 2023
@lewismc lewismc added this to the 0.9.0 milestone Feb 26, 2023
@lewismc lewismc requested a review from renato2099 February 26, 2023 05:34
@lewismc lewismc self-assigned this Feb 26, 2023
@lewismc
Copy link
Member Author

lewismc commented Feb 26, 2023

According to the Locust docs, we could also take a look at https://github.com/psycopg/psycogreen/.

@lewismc
Copy link
Member Author

lewismc commented Mar 29, 2023

@renato2099 I am going to leave off on merging this until we have reviewed more thoroughly and we especially understand the security implications.
Additionally, this all needs to be documented. Until we have that it would be unwise to merge.

@lewismc lewismc removed this from the 0.9.0 milestone Mar 29, 2023
@lewismc
Copy link
Member Author

lewismc commented Apr 19, 2023

We agreed to hold off on further development until the end of May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storage Anything tagbase-server storage/persistence related.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant