Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-205 Is TestIngest PG_VERSION Class Variable required? #212

Merged
merged 16 commits into from
Apr 10, 2023
Merged

ISSUE-205 Is TestIngest PG_VERSION Class Variable required? #212

merged 16 commits into from
Apr 10, 2023

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Apr 5, 2023

Addresses #205

@lewismc lewismc added this to the 0.10.0 milestone Apr 5, 2023
@lewismc lewismc requested a review from renato2099 April 5, 2023 23:40
@lewismc lewismc self-assigned this Apr 5, 2023
@lewismc lewismc linked an issue Apr 5, 2023 that may be closed by this pull request
Is TestIngest PG_VERSION Class Variable required? #205
Closed
@lewismc
Copy link
Member Author

lewismc commented Apr 6, 2023

@renato2099 as discussed on our call, I will address the remaining OpenAPI warnings and then push this issue. We can then release 0.10.0

@lewismc lewismc added enhancement New feature or request openapi Anything OpenAPI-related labels Apr 6, 2023
@lewismc
Copy link
Member Author

lewismc commented Apr 6, 2023 •
edited
Loading

This PR rolls in some OpenAPI syntactic changes which were required to stabilize the CI builds. This is the result of the IBM OpenAPI validator and linter which we use to quality control the OpenAPI, changing in such a way that we had to address errors and warnings.
You will note that although there are changes to the OpenAPI spec, I have NOT regenerated the python-flask project yet. This is because no functionality has changed... only the OpenAPI convention.
We can regenerate the python-flask project the next time we make functional changes to the OpenAPI spec e.g. #181

@lewismc lewismc merged commit 622383e into tagbase:main Apr 10, 2023
@lewismc lewismc deleted the ISSUE-205 branch April 10, 2023 00:33
lewismc added a commit that referenced this pull request Sep 24, 2023
@lewismc
ISSUE-205 Is TestIngest PG_VERSION Class Variable required? (#212)
d71efdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renato2099 renato2099 Awaiting requested review from renato2099

Assignees

@lewismc lewismc

Labels
enhancement New feature or request openapi Anything OpenAPI-related
Projects
No open projects
ICCAT Product Drive Phase 2 (2022-10-15 --> 2023-05-27)
Status: ✅ Done
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Is TestIngest PG_VERSION Class Variable required?
1 participant
@lewismc