Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding different port variable name #86

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Freddyminu
Copy link
Collaborator

@Freddyminu Freddyminu commented Oct 11, 2024

Decoder Description

Adding the possibility of reading the variable name fPort for ChirpStack users since the network creates the fPort variable instead of fport.

Type of change

  • Adding a new Decoder of Connector
  • Adding a new Decoder of Network
  • Update or fixing an issue in existing Decoder

Decoder Information and Payload to test and review

  • Documentation of the hardware or protocol:
  • Payload of example the test the decoder:

Checklist for Adding a New Decoder

  • Created a new folder under ./decoders/network/ or ./decoders/connector/ with the name of your decoder.
  • Added a network.jsonc or connector.jsonc file that follows the structure defined in ./schema/.
  • Created version folders and added manifest.jsonc files for each version.
  • Followed the folder structure guidelines for manufacturer and sensor/device model.
  • The code has unit test and it's in TypeScript.

Additional Notes

Please add any other information that you think is important.

const port = payload.find(
(x) => x.variable === "port" || x.variable === "fport"
);
const port = payload.find((x) => x.variable === "port" || x.variable === "fport" || x.variable === "fPort");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only modification was here.

@FabianoEger FabianoEger merged commit 7be2393 into fix/connector-axiomawaterleak Oct 14, 2024
10 checks passed
@FabianoEger FabianoEger deleted the fix/connector-dragino branch October 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants