fix: clean up ignored exhaustive deps rules, fix setup flow

tago-io · Dec 17, 2024 · 514fc5a · 514fc5a
1 parent 54fa661
commit 514fc5a
Show file tree

Hide file tree

Showing 41 changed files with 528 additions and 670 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -7,7 +7,12 @@
   },
   "files": {
     "ignoreUnknown": false,
-    "ignore": ["build", "build-tsc", "standalone-plugins", "standalone"]
+    "ignore": [
+      "build",
+      "build-tsc",
+      "standalone-plugins",
+      "standalone"
+    ]
   },
   "formatter": {
     "enabled": true,
@@ -29,8 +34,7 @@
         "noCommonJs": "error"
       },
       "correctness": {
-        "useImportExtensions": "error",
-        "useExhaustiveDependencies": "off"
+        "useImportExtensions": "error"
       },
       "suspicious": {
         "noExplicitAny": "off",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -10,8 +10,16 @@
     "node": ">=20.0.0"
   },
   "type": "module",
-  "workspaces": ["packages/*", "plugins/*"],
-  "keywords": ["platform", "iot", "tagoio", "tcore"],
+  "workspaces": [
+    "packages/*",
+    "plugins/*"
+  ],
+  "keywords": [
+    "platform",
+    "iot",
+    "tagoio",
+    "tcore"
+  ],
   "bugs": {
     "url": "https://github.com/tago-io/tcore/issues"
   },
@@ -44,7 +52,7 @@
     "zod": "3.23.8"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.9.3",
+    "@biomejs/biome": "1.9.4",
     "@swc-node/register": "1.10.9",
     "@tago-io/tcore-sdk": "0.7.2",
     "@testing-library/dom": "10.4.0",

diff --git a/packages/console/package.json b/packages/console/package.json
@@ -9,7 +9,10 @@
     "watch": "vite",
     "build": "vite build",
     "build-watch": "vite build --watch",
-    "test": "vitest"
+    "test": "vitest",
+    "lint": "biome check .",
+    "format": "biome format . --write",
+    "lint-fix": "biome check . --write"
   },
   "dependencies": {
     "@antv/g2": "4.1.23",

diff --git a/packages/console/src/App.tsx b/packages/console/src/App.tsx
@@ -103,6 +103,7 @@ const WrappedStoreRoutes = observer(() => {
     }
   }, [plugins]);
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: useEffect state machine
   useEffect(() => {
     if (status) {
       if (status.database?.error) {
@@ -131,17 +132,16 @@ const WrappedStoreRoutes = observer(() => {
         store.accountConfigured = status.account;
       });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [status]);
+  }, [status, navigate]);
 
   /**
    * Starts the socket connection.
    */
+  // biome-ignore lint/correctness/useExhaustiveDependencies: mobx observers
   useEffect(() => {
     if (store.masterPassword || store.token) {
       startSocket();
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [store.masterPassword, store.token]);
 
   if (!readyToRender) {

diff --git a/packages/console/src/Components/Action/Common/ActionFields/ActionFields.tsx b/packages/console/src/Components/Action/Common/ActionFields/ActionFields.tsx
@@ -9,9 +9,6 @@ import ActionTypePicker from "../ActionTypePicker/ActionTypePicker.tsx";
 import HttpHeaders from "../HttpHeaders/HttpHeaders.tsx";
 import MultipleAnalysis from "../MultipleAnalysis/MultipleAnalysis.tsx";
 
-/**
- * Props.
- */
 interface IActionFields {
   /**
    * Error of the fields.
@@ -178,10 +175,10 @@ function ActionFields(props: IActionFields) {
   /**
    * Sets the type into the action.
    */
+  // biome-ignore lint/correctness/useExhaustiveDependencies(action): useEffect state machine
   useEffect(() => {
     onChangeAction({ ...action, type: actionType?.id || actionType });
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [actionType]);
+  }, [actionType, onChangeAction]);
 
   return (
     <>

diff --git a/packages/console/src/Components/Action/Common/ActionTypePicker/ActionTypePicker.tsx b/packages/console/src/Components/Action/Common/ActionTypePicker/ActionTypePicker.tsx
@@ -42,9 +42,6 @@ const defaultOptions: IOption[] = [
   },
 ];
 
-/**
- * Props.
- */
 interface IActionTypePicker {
   /**
    * Option object.
@@ -166,8 +163,7 @@ function ActionTypePicker(props: IActionTypePicker) {
     if (isSchedule && props.value?.id === "tagoio") {
       props.onChange(null as any);
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [props.value, isSchedule]);
+  }, [props.value, isSchedule, props.onChange]);
 
   return (
     <OptionsPicker<IOption>

diff --git a/packages/console/src/Components/Action/Edit/ScheduleTrigger/ScheduleTrigger.tsx b/packages/console/src/Components/Action/Edit/ScheduleTrigger/ScheduleTrigger.tsx
@@ -57,7 +57,6 @@ function ScheduleTrigger(props: IScheduleTrigger) {
   useEffect(() => {
     const explanation = getCronExplanation(scheduleData.cron || "");
     setCronExplanation(explanation);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [scheduleData.cron]);
 
   const showExplanation =

diff --git a/packages/console/src/Components/Action/Edit/ScheduleTrigger/TypeScheduleOptions.tsx b/packages/console/src/Components/Action/Edit/ScheduleTrigger/TypeScheduleOptions.tsx
@@ -11,9 +11,6 @@ import type {
 import MinimumScheduleMessage from "./MinimumScheduleMessage.tsx";
 import * as Style from "./TypeScheduleOptions.style";
 
-/**
- * Props.
- */
 interface ITypeScheduleOptions {
   /**
    * Error of the fields.
@@ -34,11 +31,11 @@ function TypeScheduleOptions(props: ITypeScheduleOptions) {
   const inputRef = useRef<HTMLInputElement>(null);
   const { errors, scheduleData, onChangeScheduleData } = props;
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: useEffect auto-trigger
   useEffect(() => {
     if (inputRef.current && !scheduleData.interval) {
       inputRef.current.focus();
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [scheduleData.type]);
 
   return (