Rewrite api using async/await #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketenshi
approved these changes
Dec 9, 2021
|
|
||
| var outputs: [Result<T, Error>] = [] | ||
|
|
||
| waitUntil(timeout: .seconds(5)) { done in |
There was a problem hiding this comment.
Hope they'll add an async/await version of this to Quick
There was a problem hiding this comment.
There's an open issue there. But for now this works.
tahirmt
force-pushed
the
async-await-rewrite
branch
from
3caefa8 to
53a1f08
Compare
tahirmt
force-pushed
the
async-await-rewrite
branch
from
53a1f08 to
2db06a3
Compare
|
Can't merge it in until swift 5.5.2 is released and is on the ubuntu container. |
The default swift version is now updated
tahirmt
force-pushed
the
async-await-rewrite
branch
from
6e19bd5 to
ffe07c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since starting Xcode 13.2 we can back deploy concurrency to macOS 10.15, this library can be rewritten using async/await instead of the completion handlers hell.
closes #27