Repo sync #8
Merged
Repo sync #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host pre release Firefox version of the extension
A separate page for downloads doesn't make sense right now. Refs #52
The "community edition" is almost grown up! Remove language about being the first to try the wallet — that's no longer true 😀
We've done a lot since December!
…-all Use the "Community Edition" layout as our primary landing page
remove ff download
💥 Change banner copy to Optimism coming soon
🦋 Add "Arbitrum" to banner
mf-dapp-fb-init
* update the icon logo * set the correct height for background
Refs [#86 ](tahowallet/product-design#86) Refs [#1578 ](tahowallet/extension#1578) This PR updates the last screen. Changes were made to styles and texts. A widget with a form was embedded inside the screen. Changes: - add a typeform - text updates - add a gif - set a gradient for the background ## UI Before <img width="1709" alt="Screenshot 2023-03-14 at 15 23 04" src="https://user-images.githubusercontent.com/23117945/225031450-44290a45-cbc0-44a0-bddd-250cfb1c56e2.png"> After <img width="1709" alt="Screenshot 2023-04-03 at 12 32 28" src="https://user-images.githubusercontent.com/23117945/229485495-29f37650-1323-4f99-a8b4-0270f00db014.png">
This PR adds `padding-bottom` for social icons on the goodbye page. In some cases, the bottom space for social icons is missing on small screens. ### UI Before <img width="1252" alt="Screenshot 2023-04-10 at 13 51 16" src="https://user-images.githubusercontent.com/23117945/230896494-ea785584-d21f-4e5b-859b-506387c8010f.png"> After <img width="1254" alt="Screenshot 2023-04-10 at 13 53 40" src="https://user-images.githubusercontent.com/23117945/230896808-660258a2-3b66-4f21-81c2-6af0bcfe602f.png">
Resolves tahowallet/taho.xyz#171 Fix links and copy using old name
jagodarybacka
requested changes
Jul 11, 2023
There was a problem hiding this comment.
- we should actually run linter and format the codebase
- there are problems with types (some packages apparently don't have corresponding types packages installed - see react-helmet)
- new typescript config is breaking imports, we have to add base url
- ts config in manifesto dapp backend is different from the one we use on the repo level, I don't see a reason why they should be different
We can enable it later after typescript will be updated to higher version.
|
Ok, everything I've noticed was fixed except problems with firebase imports here but they are on the main taho.xyz as well so let's maybe not waste a lot more time right now - there is a long thread on possible solutions. Lmk what you think about that typescript config in the manifesto backend @hyphenized (it is non-blocking) and please take a look at the commits I've added. |
jagodarybacka
approved these changes
Jul 11, 2023
|
Updated the typescript version at the root level as I don't want us to have to deal with anything lower than the current version we're working with in the extension. The manifesto dapp has it's own This is ready to be merged cc @Shadowfiend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs the repo state with @tahowallet/taho.xyz