Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add documentation for gui system and install trouble shooting. #2985

Merged
merged 12 commits into from
Oct 8, 2021

Conversation

Leonz5288
Copy link
Contributor

@Leonz5288 Leonz5288 commented Sep 24, 2021

Work in progress.
Made new folder static/asset under articles. I use this to store example images in docs.

@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: e4b90be

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6154634e17c3d30008d019e5

😎 Browse the preview: https://deploy-preview-2985--jovial-fermat-aa59dc.netlify.app

@k-ye
Copy link
Member

k-ye commented Sep 24, 2021

Question: I want to put some example images. Where should I save them?

One option would be to use https://github.com/taichi-dev/public_files. If we create a new folder under docs/lang/ to hold these static resources, can netlify correctly handle them? @rexwangcc :-)

@Leonz5288
Copy link
Contributor Author

Question: I want to put some example images. Where should I save them?

One option would be to use https://github.com/taichi-dev/public_files. If we create a new folder under docs/lang/ to hold these static resources, can netlify correctly handle them? @rexwangcc :-)

I had a conversation with @rexwangcc and concluded that adding a static/asset folder for example images would be great.

@k-ye k-ye added the skip ci label Sep 24, 2021
@k-ye
Copy link
Member

k-ye commented Sep 26, 2021

nit: static/assets

@Leonz5288 Leonz5288 marked this pull request as ready for review September 26, 2021 11:47
@Leonz5288
Copy link
Contributor Author

/format

@@ -16,7 +16,7 @@ python3 -m pip install taichi
```

:::note
Currently, Taichi only supports Python 3.6/3.7/3.8 (64-bit).
Currently, Taichi only supports Python 3.6/3.7/3.8/3.9 (64-bit).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we take this opportunity to schedule Taichi's deprecation for 3.6 by 2022 :-)? https://endoflife.date/python @ailzhang @Zheaoli @strongoier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Maybe we should mention that taichi'll do one major verison official release for 3.6 after its EOL and then we'll stop py36 releases?

Copy link
Contributor

@Zheaoli Zheaoli Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Maybe we can make a deprecated roadmap/strategy to get a major version to drop the Python 3.6 support, then we can add log info to show the deprecated warning. After this, the developer will get some information when they execute import taichi in Python 3.6

docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved

The color of triangles can be further specified with additional parameter.

For example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline for code blocks and headers

@Leonz5288 Leonz5288 requested a review from k-ye September 28, 2021 07:49
Copy link
Member

@ltt1598 ltt1598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the GUI system once.
We might need an extra pass of fixing format and grammar.

docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
```python
gui.circles(pos, radius=3, color=0x068587)
```
draws circles all with radius of 1.5 and blue color positioned at pos array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the radius argument in gui.circles means diameter right? This might confuse people.

Also, we should mention the unit of the digit radius=3 here, is this number of pixels or something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming requires modify python API code. I think we should leave this to another PR and focus on docs changing in this one.

docs/lang/articles/misc/gui.md Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
docs/lang/articles/misc/gui.md Show resolved Hide resolved
docs/lang/articles/misc/gui.md Outdated Show resolved Hide resolved
[`ti.imresize(img, w)`](https://api-docs.taichi.graphics/src/taichi.misc.html?highlight=imresize#taichi.misc.image.imresize)
resizes the img specified.

## Zero-copying frame buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any limitation of this option? Why fast_gui is not a default choice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the limitation is in the caution part.

Copy link
Member

@ltt1598 ltt1598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you so much for the edtting.

@strongoier strongoier merged commit 225dbb2 into taichi-dev:master Oct 8, 2021
@Leonz5288 Leonz5288 deleted the docs branch October 8, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants