Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update Type system #3043

Merged
merged 23 commits into from
Sep 30, 2021
Merged

[Doc] Update Type system #3043

merged 23 commits into from
Sep 30, 2021

Conversation

ltt1598
Copy link
Member

@ltt1598 ltt1598 commented Sep 29, 2021

Related issue = #

ltt1598 and others added 21 commits September 26, 2021 16:45
@ltt1598
change numbers
e3a0e3a
@ltt1598
Change supported data type table
174021d 
-- remove C Source
++ add Vulkan
@ltt1598
Update compound type field instantiation
533a17a 
Make it consistent with the `#is equivalent to` in the precision section.
@ltt1598
Fixed a missed change in vec2i
8db506e
@ltt1598
Change the code snippets in type casting section
9b223a0 
Emphasize that all the type casting ops are in the Taichi scope.
@ltt1598
Fix a bug in the original doc
efd25d4
@ltt1598
Change numbers
f08dbf8
@ltt1598
Add an example for ti.bit_cast()
fe67fcd
@ltt1598
Rename bit casting to bit casts
7a39024 
Use cast as a noun.
Make it consistent with the explicit and implicit casts.
@ltt1598
Fix typo
2a3dd66
@ltt1598
Fix missed changes in my_types
f6848f0
@ltt1598
Change names for variables
3a84150
@ltt1598
Add description for structs
8c4b85e
@ltt1598
Change numbers
836f391
@ltt1598
Change numbers
5c86042
@ltt1598
Fix glitches
76007d7
@ltt1598 @yuanming-hu
Fix typos for docs/lang/articles/basic/type.md
219b3eb 
commit suggestions from Yuanming

Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@ltt1598
Fix typos
38979d8 
determinated -> determined
it's -> its
@strongoier
Merge branch 'master' into master
72431ce
@ltt1598
fix typo
1205aac 
floating pointer -> floating point
@ltt1598
Change highlight lines
6153c4f
@netlify
Copy link

netlify bot commented Sep 29, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: b56592a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61541f6b2e6c7e00070551b7

😎 Browse the preview: https://deploy-preview-3043--jovial-fermat-aa59dc.netlify.app

@ltt1598
Copy link
Member Author

ltt1598 commented Sep 29, 2021

Noticed that the code highlight was wrong. I couldn't see the highlight in my local MD editor.
They should be fixed now.

@strongoier
Copy link
Contributor

Noticed that the code highlight was wrong. I couldn't see the highlight in my local MD editor. They should be fixed now.

You could use https://deploy-preview-3043--jovial-fermat-aa59dc.netlify.app/docs/lang/articles/basic/type to see the preview :-)

A few nits:

  • In the Implicit casts subsection, what about highlighting the lines actually doing implicit type casting instead of print?
  • Would you try to rebase your repo from the latest Taichi repo? It seems that the commits shown here are mixed with your last PR.

@ltt1598
Copy link
Member Author

ltt1598 commented Sep 29, 2021

Updated.

Is there a way to find the preview link?

@strongoier
Copy link
Contributor

Updated.

Is there a way to find the preview link?

There is a netlify bot in this PR. Search Browse the preview in this webpage and you'll find it :-)

strongoier
strongoier approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@strongoier strongoier merged commit 197497e into taichi-dev:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltt1598 @strongoier