Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix an example in the documentation for coordinate offsets #3089

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[Doc] Fix an example in the documentation for coordinate offsets #3089

merged 1 commit into from
Oct 6, 2021

Conversation

0xrabbyte
Copy link
Contributor

Related issue = #
I think the original example given in the code is not right according to Ln 18.

@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 70137ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/615c329fac60080007e544a1

😎 Browse the preview: https://deploy-preview-3089--jovial-fermat-aa59dc.netlify.app

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Taichi community! Thanks for catching this! Would you please sign the CLA so that the PR can be merged after passing CI?

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, @0xrabbyte! Thanks for the contribution. Fixing this error will make readers better understand the coordinate offset system. It's interesting that the error stays there for this long :-)

@yuanming-hu yuanming-hu changed the title [Doc] Fix an example in the documentation for Coordinate offsets [Doc] Fix an example in the documentation for coordinate offsets Oct 6, 2021
@yuanming-hu yuanming-hu merged commit fce9108 into taichi-dev:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants