Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenGL] Fix minor bugs in GL Device #3091

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Oct 6, 2021

(Maybe) Related issue = #3069

  • glCreateBuffers is the DSA variants of creating objects, since we are targeting GL4.3 without DSA, we should use genBuffers
  • This might have caused the issue ti.init(arch=ti.opengl) failed with Taichi 0.8.1 #3069, however I'm not sure and I don't have intel device to test this with. Detailed theory will be posted in the issue
  • Caught another small bug (not impacting anything yet) as we forgot to record the offset field of the clear buffer command

@netlify
Copy link

netlify bot commented Oct 6, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: dd7cee3

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/615d3de06907580007c84bb0

@bobcao3 bobcao3 requested a review from k-ye October 6, 2021 06:15
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bobcao3 bobcao3 merged commit 1e996b1 into taichi-dev:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants