[perf] Reduce SNodeTree materialization time in LLVM backends #3127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
Thanks to @qiao-bo for his experiments on memory allocators, which gives me insights. This PR is mainly based on the profiling results of the following code snippet:
Before this PR, the profiling result is:
The bottleneck part is triggered by the
update_runtime_jit_module()
function I'm removing here. In fact, we only need to feed our generated module with latest SNodeTree types as well as compiled kernels into LLVM passes when we're going to run kernels (and we're actually doing this). Therefore, this function call, which happens immediately after SNodeTree materialization, is redundant.After this PR, the profiling result is:
We can see the total running time decreases from ~130s to ~20s, which is ~6.5x speedup.