Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable macos 10.14 in release.yml. #3158

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Oct 11, 2021

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 460a9ab

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61643d2fd0f2cf0008fdbb84

k-ye
k-ye previously approved these changes Oct 11, 2021
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Our mac CI is becoming hopeless....)

@ailzhang ailzhang changed the title [ci] Enable macos 10.14 in release.yml wip. [ci] Enable macos 10.14 in release.yml. Oct 11, 2021
@ailzhang
Copy link
Contributor Author

cc: @k-ye this one is ready for review :D

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang
Copy link
Contributor Author

Merging as this PR is not related to presubmit checks

@ailzhang ailzhang merged commit 764fc90 into taichi-dev:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release should cover OSX 10.14
2 participants