Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove redundant code in snode_rw_accessors_bank #3192

Merged

Conversation

strongoier
Copy link
Contributor

Related issue = #

L42, which expands to

void set_kernel_args(const std::vector<int> &I,
int num_active_indices,
Kernel::LaunchContextBuilder *launch_ctx) {
for (int i = 0; i < num_active_indices; i++) {
launch_ctx->set_arg_int(i, I[i]);
}
}
, does exactly the same thing as the removed L43-45. Therefore L43-45 are redundant.

@netlify
Copy link

netlify bot commented Oct 14, 2021

❌ Deploy Preview for jovial-fermat-aa59dc failed.

🔨 Explore the source changes: 42da614

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6167dd03b47b070007a58bb4

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 😂

@strongoier strongoier merged commit 7856f73 into taichi-dev:master Oct 14, 2021
@strongoier strongoier deleted the fix-snode-rw-accessors-bank branch October 22, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants