Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Use ti.linalg.sparse_matrix_builder as kernel parameters #3210

Merged

Conversation

Hanke98
Copy link
Collaborator

@Hanke98 Hanke98 commented Oct 17, 2021

Related issue = #2906 #3200

Use ti.linalg.sparse_matrix_builder() to replace ti.sparse_matrix_builder() as the kernel paremater annotation.
Note that the doc will be updated in the next pr, after #3200 being merged.

@netlify
Copy link

netlify bot commented Oct 17, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 28440ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/616b9a56cbf54000080956f1

@Hanke98 Hanke98 changed the title [Lang] Use ti.linalg.sparse_matrix_builder as kernel parameters [Lang] Use ti.linalg.sparse_matrix_builder as kernel parameters Oct 17, 2021
@Hanke98
Copy link
Collaborator Author

Hanke98 commented Oct 17, 2021

/format

Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hanke98. LGTM!

@Hanke98 Hanke98 requested a review from k-ye October 18, 2021 01:55
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit ec18657 into taichi-dev:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants