Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Optimize Expression::serialize #3221

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[refactor] Optimize Expression::serialize #3221

merged 2 commits into from
Oct 19, 2021

Conversation

TennyZhuang
Copy link
Contributor

Related issue = #3208

  • Modify the signature of Expression::serialize to reduce allocation.
  • Create an overloadded serialize (also keep original serialize here)

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 18, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: c6cb005

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/616dc9f3e1185b00084c0a8e

@strongoier strongoier changed the title refactor: optimize Expression::serialize [refactor] Optimize Expression::serialize Oct 19, 2021
@TennyZhuang TennyZhuang changed the title [refactor] Optimize Expression::serialize [refactor] optimize Expression::serialize Oct 19, 2021
@TennyZhuang TennyZhuang changed the title [refactor] optimize Expression::serialize [refactor] Optimize Expression::serialize Oct 19, 2021
k-ye
k-ye approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@k-ye k-ye merged commit 03520a6 into taichi-dev:master Oct 19, 2021
@strongoier strongoier mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TennyZhuang @CLAassistant @k-ye