Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Fix fence timeout #3229

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[vulkan] Fix fence timeout #3229

merged 2 commits into from
Oct 19, 2021

Conversation

AmesingFlank
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Oct 19, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: d4b7387

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/616ee82db80040000963d9b5

@bobcao3
Copy link
Collaborator

bobcao3 commented Oct 19, 2021

lmao, should we just make it UINT64_MAX so that extremely long compute will survive?

k-ye
k-ye approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for making this max 😂

@AmesingFlank
Copy link
Collaborator Author

sounds good, max it is

@AmesingFlank AmesingFlank merged commit df90bb3 into taichi-dev:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@bobcao3 bobcao3 Awaiting requested review from bobcao3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmesingFlank @bobcao3 @k-ye