Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Remove the dataclass decorator from CuptiMetric, as it is not supported in Python 3.6 #3246

Merged
merged 1 commit into from
Oct 21, 2021
Merged

[Bug] Remove the dataclass decorator from CuptiMetric, as it is not supported in Python 3.6 #3246

merged 1 commit into from
Oct 21, 2021

Conversation

yolo2themoon
Copy link
Collaborator

@yolo2themoon yolo2themoon commented Oct 21, 2021 •
edited
Loading

Related issue = #3049

Hmm, dataclass is a 3.7+ feature, could you fix that?

Originally posted by @k-ye in #3049 (comment)

@netlify
Copy link

netlify bot commented Oct 21, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 07b3b22

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/617177167368bc00080259fa

@yolo2themoon yolo2themoon mentioned this pull request Oct 21, 2021
Merged
k-ye
k-ye approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k-ye k-ye merged commit 421cdb4 into taichi-dev:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yolo2themoon @k-ye